Forum Discussion
Microsoft Forms : file uploads fail in existing questions, while new upload questions work
Your own testing has already pinpointed it — this is the expired sharing-link problem Microsoft documents for Forms file uploads, not a problem with the files or the folders. When a file upload question is created, Forms relies on a People in your organization sharing link to the OneDrive folder. If the tenant sets an expiry on those links, they stop working after that many days, which is exactly why the older questions fail with a 403 and a link-expired page while a brand-new question works.
Microsoft's own troubleshooting write-up for this is blunt about the fix: if the links are expired, the file upload questions have to be deleted and re-created. There isn't a way to renew the link on an existing question in place. The new question gets a fresh link and a new subfolder, and the files already uploaded stay where they are.
Before you re-create twenty questions, it's worth getting the tenant setting checked, or the same thing will happen again. A SharePoint admin can check the OneDrive expiry with Get-SPOTenant -OneDriveOrganizationSharingLinkMaxExpirationInDays, and the SharePoint equivalent with Get-SPOTenant -CoreOrganizationSharingLinkMaxExpirationInDays for group forms. If a number of days is set there, that's your expiry, and it needs to be lengthened or removed if the forms are meant to keep working long term.
One practical point for your flows: since a re-created question stores uploads in a new folder, the Power Automate flows that pull the photos will need to point at the new folders. I'd do one form end to end first — re-create its upload question, test an upload, and update its flow — before touching the other nineteen.