Forum Discussion
VBA to delete rows whose cell in a column has length zero
- May 26, 2023
How about
Sub TestDeleteRow() Dim wb As Workbook Dim ws As Worksheet Dim tblTest As ListObject Dim ChildNumColumn As Range Dim LastRow As Long Dim i As Long Set wb = ThisWorkbook Set ws = wb.Worksheets("Test") Set tblTest = ws.ListObjects("Test_T") ' Define the table column Data Body Range where we will be checking if the cell's length is 0 Set ChildNumColumn = tblTest.ListColumns("Child #").DataBodyRange LastRow = ChildNumColumn.Rows.Count For i = LastRow To 1 Step -1 If Len(ChildNumColumn.Cells(i).Value) = 0 Then tblTest.ListRows(i).Delete End If Next i End Sub
The runtime error 1004 occurs because you are modifying the range while iterating through it in the loop. Deleting rows inside the loop changes the number of rows in the range, causing the runtime error.
To overcome this issue, you can loop through the cells in reverse order, starting from the last cell and moving upwards. Deleting rows from the bottom up ensures that the row deletions do not affect the loop.
Here's an updated version of your code that uses a reverse loop to delete rows with empty cells in the "Child #" column:
Sub TestDeleteRow()
Dim wb As Workbook
Dim ws As Worksheet
Dim tblTest As ListObject
Dim ChildNumColumn As Range
Dim LastRow As Long
Dim i As Long
Set wb = ThisWorkbook
Set ws = wb.Worksheets("Test")
Set tblTest = ws.ListObjects("Test_T")
' Define the table column Data Body Range where we will be checking if the cell's length is 0
Set ChildNumColumn = tblTest.ListColumns("Child #").DataBodyRange
LastRow = ChildNumColumn.Rows.Count
For i = LastRow To 1 Step -1
If Len(ChildNumColumn.Cells(i).Value) = 0 Then
ChildNumColumn.Cells(i).EntireRow.Delete
End If
Next i
End Sub
By iterating through the cells in reverse order, the loop won't be affected by the row deletions, and it will correctly delete the rows where the cell in the "Child #" column has a length of zero.
- Antonino2023May 26, 2023Brass Contributor
Thank you for the explanation! The code changes make sense, but I used your code and received the same error "Delete method of Range class failed".
- HansVogelaarMay 26, 2023MVP
How about
Sub TestDeleteRow() Dim wb As Workbook Dim ws As Worksheet Dim tblTest As ListObject Dim ChildNumColumn As Range Dim LastRow As Long Dim i As Long Set wb = ThisWorkbook Set ws = wb.Worksheets("Test") Set tblTest = ws.ListObjects("Test_T") ' Define the table column Data Body Range where we will be checking if the cell's length is 0 Set ChildNumColumn = tblTest.ListColumns("Child #").DataBodyRange LastRow = ChildNumColumn.Rows.Count For i = LastRow To 1 Step -1 If Len(ChildNumColumn.Cells(i).Value) = 0 Then tblTest.ListRows(i).Delete End If Next i End Sub
- Antonino2023May 26, 2023Brass Contributor
That worked!
Would the source of the prior error be that ChildNumColumn is referencing ListColumns("Child #"), so when I was trying to delete a row in the loop, it was running into an issue where it could not delete the cell in column "Child #" without affecting the other cells in that row? (In the sense that I was trying to delete the entire row in ONLY column "Child #" as opposed to the entire row of the table itself)