The most efficient way to share documents?

To put it (very) simply: OneDrive for Business is the cloud "equivalent" of a local "Documents" folder and so it is meant to store the personal work files and folders of a user.

Hence, yes, you made a big mistake... Most (perhaps all!) of your problems come from such mistake!

Instead, the cloud "equivalent" of a network share is a SharePoint document library which is meant to store the files and folders shared among the users in a team.

All this said, you should realize that SharePoint is a quite complex environment, designed to fulfill hugely different requirements in several different ways: therefore a perfect understanding of your requirements and a perfect understanding of alternatives in implementation is paramount. 

A lot depends on your permissions requirements: do you want that everyone is able to access everything? Do you want to share with external users, i.e. not belonging to your organization?

Also, do you need only files and folders sharing or do you need some wider type of collaboration? In such case, Teams/Groups could be the correct answer.

All these subjects, and many more, have been repeatedly discussed in this community, so my advice is to search for relevant threads and read a lot. Or look for a SharePoint professional that can help you.

In any case, planning is the key.

Good luck!

Hi Alex!

That was a difficult question and the answer is "It depends" :-)

There is no silver bullet for how to implement SharePoint. Depending on what your needs are there are different answers. When i use SharePoint now is often for

Intranets and then i set up Communication Sites for news publishing and common internal document sharing.

When it comes to "Project sites" i prefer to use Microsoft Teams. When You create a team, there will also be created an Office 365 Group and a SharePoint Site. The team members have access to everything in the team (and its SharePoint site) so if You, like You mention, have very specific access restrictions it can be difficult to handle that with/in Teams.

If your access restrictions are very specific You can handle the access in many levels using SharePoint (Site Collection, Site, Library, folders, items). My advice is to handle the access on an as high level as possible, otherwise it gets messy very soon.

Using SharePoint for Project Sites and Site- and Document Sharing with both Internal and External users i recommend that You split them between Internal and External Site Collections ( this is the "old way") so that You have "Internal Projects" and "External Projects", then You can configure the internal site collections so that their subsites and their content are not possible to share with external users by accident. Have You considered using Office 365 Groups?

Regardless of what You choose to use it takes a great deal of planning in advance. If you go for classic SharePoint i recommend that you start by reading "SharePoint Online Planning Guide for Office 365 for business" but based on the needs i think You have the best solution for You is to use Microsoft Teams/Office 365 Groups.

Hope that this helped You a little instead of making You confused on a higher level.

Best regards and good luck, Magnus