Forum Discussion
slow after running macro
Hi Bruce,
We need to see this macro to figure out what the problem is.
Please copy the macro code here in a reply.
It would be better if you can attach the workbook itself.
Regards
- bruce carskadonJul 23, 2018Copper Contributor
Hi Haytham,
Thanks for taking the time to look at it.
I have attached a copy of the workbook (I have put random names in the name column, but that does not affect the macro). I am not a sophisticated programmer and don’t know all the shortcuts in coding, but the macro does what I want it to do, it just takes too much time, and once it exits, the workbook is slow to navigate until I close it and reopen it.
The macro does two basic procedures:
- it compares the raw data from golfers scores, computes the senior handicaps and compares it to the course handicap
- it takes the individual raw data, sorts by name, and prepares a printable version for each player.
If you see a fix, just send me a copy to the revised macro with any comments you want to make.
Thanks,
Bruce
- Haytham AmairahJul 25, 2018Silver Contributor
Hi Bruce,
Sorry on the late reply!
The macro performs a very long operation, and includes several For Loops statements, this is why it takes too much time!
Another reason, there are too many Conditional Formatting rules in the worksheet!
However, I've updated the macro to speed up the operation, please test it in the attached file.
Also, please review Conditional Formatting rules in the worksheet and see if you really need them all.
Regards
- bruce carskadonJul 25, 2018Copper Contributor
Hi Haytham,
Thanks so much. It runs much faster. I saw you added some code at the front of my macro - one of which doesn't allow the macro to update the screen which I could see takes a huge amount of time. I'm not sure what the others do, but if you could point me to where I could find out, I'd appreciate it. I need the conditional formatting so it is easy for the other golfers to visually see how they are doing and what holes they need to work on.
You have been a big help!
Bruce