Forum Discussion

josh_bodner's avatar
josh_bodner
Former Employee
May 12, 2021

Dev channel update to 92.0.884.2 is live

Hello Insiders!  Today we’re releasing build 92.0.884.2 to the Dev channel.  Our biggest news isn’t with the Dev channel though; it’s that with the most recent Beta release, which brings it to versio...
josh_bodner's avatar
josh_bodner
Former Employee
May 12, 2021

rshupak oh and also, for the SSO issue, can you try clearing your cookies and seeing if that helps?  If you're signed into Edge with your MSA, you're right that it's what should be used for SSO instead of your AAD account, which makes me think that maybe your AAD credentials are just saved and being used, and so getting rid of them may help.  

rshupak's avatar
rshupak
Iron Contributor
May 13, 2021
It occurs on multiple devices and channels all of which are configured to clear all but a few cookies on exit and no login cookies are preserved. It is in part a problem with this site as I have had this problem with the old Edge both here and on a few other Microsoft sites. It can be done correctly since some sites work. It seems worse with the new Edge feature which is also broken on https://www.office.com and https://portal.azure.com. https://developer.microsoft.com/en-us/graph/graph-explorer is one site which defaults to the AAD account but prompts for account selection before signing in.
  • josh_bodner's avatar
    josh_bodner
    Former Employee
    May 21, 2021

    rshupak for the settings page crashing when you search, we've actually made a few fixes this week that should make their way into next week's Dev.  A couple of those crashes were only on Mac, and I use Windows machines, so that's likely why I wasn't seeing them.  

     

    As for the SSO behavior, I think I may have initially misunderstood what your problem was.  The setting to "Allow single sign-on for work or school sites using this profile" actually forces SSO using your AAD account when it's turned on since AAD is the same as a work/school account (and thus MSA equals personal).  So, since it sounds like that setting is working as intended, I think the problem is maybe that this website support both kinds of logins, and thus the problem is with the site?  If so, that's feedback you should definitely give to the site.  

    • rshupak's avatar
      rshupak
      Iron Contributor
      May 25, 2021

      josh_bodner I don't know if I didn't try this scenario or if it regressed but these settings are still broken in canary Version 92.0.899.0 (Official build) canary (64-bit).

       

      First, when opening edge://settings/content still starts with an error

       

      GET edge://resources/js/cr/ui/command.js net::ERR_FAILED
      assert.js:85 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ assert.js:85
      util.js:320 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ util.js:320
      promise_resolver.js:84 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ promise_resolver.js:84
      icon.js:159 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ icon.js:159
      define @ cr.js:295
      (anonymous) @ icon.js:7
      ui.js:213 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ ui.js:213
      define @ cr.js:295
      (anonymous) @ ui.js:5
      keyboard_shortcut_list.js:94 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ keyboard_shortcut_list.js:94
      define @ cr.js:295
      (anonymous) @ keyboard_shortcut_list.js:5
      parse_html_subset.js:218 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ parse_html_subset.js:218
      load_time_data.js:215 crbug/1173575, non-JS module files deprecated.
      (anonymous) @ load_time_data.js:215

       

      This page has a Recent activity section which I believe was a factor in the previous bug that was fixed.  In my case, this section lists three sites only one of which has had any recent change in permissions.  The first, which hasn't changed recently is https://ntp.msn.com/

       

       

      When I click on the > on the right, this opens edge://settings/content/siteDetails which curiously lacks any query string to indicate what site it is trying to display.  Regardless, this fails with

       

      lib_react.chunk.js:9 Error: Unexpected condition on edge://settings/content/siteDetails: Could not find value for siteSettingsSourceDrmDisabled
      at expect (load_time_data.js:191)
      at LoadTimeData.getValue (load_time_data.js:57)
      at LoadTimeData.getString (load_time_data.js:67)
      at YT.getSublabelText (settings.bundle.js:1)
      at settings.bundle.js:1
      at Array.map (<anonymous>)
      at YT.renderSelectRows (settings.bundle.js:1)
      at YT.render (settings.bundle.js:1)
      at Ha (lib_react.chunk.js:9)
      at Ua (lib_react.chunk.js:9)
      at ku (lib_react.chunk.js:9)
      at ml (lib_react.chunk.js:9)
      at vl (lib_react.chunk.js:9)
      at ul (lib_react.chunk.js:9)
      at lib_react.chunk.js:9
      at t.unstable_runWithPriority (lib_common.chunk.js:38)
      at Bi (lib_react.chunk.js:9)
      at Yi (lib_react.chunk.js:9)
      at qi (lib_react.chunk.js:9)
      at ll (lib_react.chunk.js:9)
      at Object.notify (lib_react.chunk.js:17)
      at e.t.notifyNestedSubs (lib_react.chunk.js:17)
      at e.t.handleChangeWrapper (lib_react.chunk.js:17)
      at g (lib_react.chunk.js:25)
      at lib_react.chunk.js:25
      at dispatch (lib_react.chunk.js:25)
      at settings.bundle.js:1
      iu @ lib_react.chunk.js:9
      n.callback @ lib_react.chunk.js:9
      go @ lib_react.chunk.js:9
      su @ lib_react.chunk.js:9
      Sl @ lib_react.chunk.js:9
      t.unstable_runWithPriority @ lib_common.chunk.js:38
      Bi @ lib_react.chunk.js:9
      wl @ lib_react.chunk.js:9
      ul @ lib_react.chunk.js:9
      (anonymous) @ lib_react.chunk.js:9
      t.unstable_runWithPriority @ lib_common.chunk.js:38
      Bi @ lib_react.chunk.js:9
      Yi @ lib_react.chunk.js:9
      qi @ lib_react.chunk.js:9
      ll @ lib_react.chunk.js:9
      notify @ lib_react.chunk.js:17
      t.notifyNestedSubs @ lib_react.chunk.js:17
      t.handleChangeWrapper @ lib_react.chunk.js:17
      g @ lib_react.chunk.js:25
      (anonymous) @ lib_react.chunk.js:25
      dispatch @ lib_react.chunk.js:25
      (anonymous) @ settings.bundle.js:1
      async function (async)
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ lib_react.chunk.js:25
      (anonymous) @ settings.bundle.js:1
      Promise.then (async)
      componentWillMount @ settings.bundle.js:1
      To @ lib_react.chunk.js:9
      Ua @ lib_react.chunk.js:9
      ku @ lib_react.chunk.js:9
      ml @ lib_react.chunk.js:9
      vl @ lib_react.chunk.js:9
      ul @ lib_react.chunk.js:9
      (anonymous) @ lib_react.chunk.js:9
      t.unstable_runWithPriority @ lib_common.chunk.js:38
      Bi @ lib_react.chunk.js:9
      Yi @ lib_react.chunk.js:9
      qi @ lib_react.chunk.js:9
      j @ lib_react.chunk.js:9
      Yt @ lib_react.chunk.js:9
      settings.bundle.js:1 Uncaught (in promise) Error: Unexpected condition on edge://settings/content/siteDetails: Could not find value for siteSettingsSourceDrmDisabled
      at expect (load_time_data.js:191)
      at LoadTimeData.getValue (load_time_data.js:57)
      at LoadTimeData.getString (load_time_data.js:67)
      at YT.getSublabelText (settings.bundle.js:1)
      at settings.bundle.js:1
      at Array.map (<anonymous>)
      at YT.renderSelectRows (settings.bundle.js:1)
      at YT.render (settings.bundle.js:1)
      at Ha (lib_react.chunk.js:9)
      at Ua (lib_react.chunk.js:9)
      at ku (lib_react.chunk.js:9)
      at ml (lib_react.chunk.js:9)
      at vl (lib_react.chunk.js:9)
      at ul (lib_react.chunk.js:9)
      at lib_react.chunk.js:9
      at t.unstable_runWithPriority (lib_common.chunk.js:38)
      at Bi (lib_react.chunk.js:9)
      at Yi (lib_react.chunk.js:9)
      at qi (lib_react.chunk.js:9)
      at ll (lib_react.chunk.js:9)
      at Object.notify (lib_react.chunk.js:17)
      at e.t.notifyNestedSubs (lib_react.chunk.js:17)
      at e.t.handleChangeWrapper (lib_react.chunk.js:17)
      at g (lib_react.chunk.js:25)
      at lib_react.chunk.js:25
      at dispatch (lib_react.chunk.js:25)
      at settings.bundle.js:1
      expect @ load_time_data.js:191
      getValue @ load_time_data.js:57
      getString @ load_time_data.js:67
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ settings.bundle.js:1
      render @ settings.bundle.js:1
      Ha @ lib_react.chunk.js:9
      Ua @ lib_react.chunk.js:9
      ku @ lib_react.chunk.js:9
      ml @ lib_react.chunk.js:9
      vl @ lib_react.chunk.js:9
      ul @ lib_react.chunk.js:9
      (anonymous) @ lib_react.chunk.js:9
      t.unstable_runWithPriority @ lib_common.chunk.js:38
      Bi @ lib_react.chunk.js:9
      Yi @ lib_react.chunk.js:9
      qi @ lib_react.chunk.js:9
      ll @ lib_react.chunk.js:9
      notify @ lib_react.chunk.js:17
      t.notifyNestedSubs @ lib_react.chunk.js:17
      t.handleChangeWrapper @ lib_react.chunk.js:17
      g @ lib_react.chunk.js:25
      (anonymous) @ lib_react.chunk.js:25
      dispatch @ lib_react.chunk.js:25
      (anonymous) @ settings.bundle.js:1
      async function (async)
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ settings.bundle.js:1
      (anonymous) @ lib_react.chunk.js:25
      (anonymous) @ settings.bundle.js:1
      Promise.then (async)
      componentWillMount @ settings.bundle.js:1
      To @ lib_react.chunk.js:9
      Ua @ lib_react.chunk.js:9
      ku @ lib_react.chunk.js:9
      ml @ lib_react.chunk.js:9
      vl @ lib_react.chunk.js:9
      ul @ lib_react.chunk.js:9
      (anonymous) @ lib_react.chunk.js:9
      t.unstable_runWithPriority @ lib_common.chunk.js:38
      Bi @ lib_react.chunk.js:9
      Yi @ lib_react.chunk.js:9
      qi @ lib_react.chunk.js:9
      j @ lib_react.chunk.js:9
      Yt @ lib_react.chunk.js:9

       

       

    • rshupak's avatar
      rshupak
      Iron Contributor
      May 23, 2021

      josh_bodner 

       

      The settings pages were fixed last week. The problem I reported was on Windows not Mac. It depended on your specific cookie settings to fail which I why you did not see it. I didn't see it on PCs which had different settings. The problem settings are obviously ones that do not roam though Edge doesn't identify what does and does not roam so that doesn't help anyone.

       

      In regard to SSO, let me remind you of the text of the setting

       

      Allow single sign-on for work or school sites using this profile

       

      If this setting is on, you’ll be able to access work or school sites on this device using this profile. If this setting is off, you’ll need to switch to your work or school account profile to use single sign-on.

       

      Note that it describes enabling or disabling AAD SSO.  It does not make any mention of switching from MSA SSO to AAD only SSO.  If the latter is intended, the text should be updated to be accurate which it is not.

       

      I need to find a PC with the old Edge but I am pretty sure that the old Edge supported SSO for MSA and AAD simultaneously.  I can't see it worked well on all sites because it likely didn't work on a site like this one which supports both.  It appears that the identity team does not provide any mechanism for sites supporting both MSA and AAD to work well but maybe it does and no Microsoft site has implemented this.

       

      It does appear from https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-js-prompt-behavior that clients can force an account selection always while the default is not to prompt when there is only a single AAD account authenticated.  There is no mention of MSA on this page though MSAL and the v2.0 endpoint do explicitly note support for MSA elsewhere.  Maybe the endpoint itself isn't functional enough to handle this correctly.