Forum Discussion

Mike Jansen's avatar
Mike Jansen
Iron Contributor
Jun 12, 2017

Sharepoint framework > reference to custom javascript

I try to convert an "old" content editor webpart to a SharePoint Modern webpart. My original script contains a few references to custom .js files. In my new solution I added this to my "webpart.ts" f...
Mike Jansen's avatar
Mike Jansen
Iron Contributor
Jun 13, 2017

After a day of searching and testing, i found this:

https://blog.mastykarz.nl/bundling-external-frameworks-sharepoint-framework-client-side-web-parts-bad-idea/

 

Looks like my idea of bundling my javascripts file in the webpart is not the best approach. I know put them on my Sharepoint site (site assets) and referenced them in the "config.json" file. No more build errors so we are getting somewhere.

 

However, suppose I want to distribute my webpart to different tenants, what might be the best place to put my .js files? Azure somewhere? Or is there a better solution?

  • Pieter Veenstra's avatar
    Pieter Veenstra
    MVP
    Jun 13, 2017

    Hi Mike Jansen,

     

    You could put those scripts anywhere ( as long as they are accesible).

     

    Have you looked at the Azure CDN?

     

     

    • Pieter Veenstra's avatar
      Pieter Veenstra
      MVP
      Jun 13, 2017

      Is there a reason why your not just migrating your scripts to TypeScript?

       

      Something like this is easy to implement and closer to where you should want to be:

       

      export default class MyFunctionsTurnedIntoAClass {

    public oldfunction1() {
      ....
    }

    public oldfunction2() {
        ....
    }

    ....
}

       

      • Mike Jansen's avatar
        Mike Jansen
        Iron Contributor
        Jun 13, 2017

        Yes ;-)

        This is my first test and I am not familiar with Typescript. What I try to do is get my test working and then step-by-step convert it to typescript.

    • Mike Jansen's avatar
      Mike Jansen
      Iron Contributor
      Jun 13, 2017

      Pieter Veenstra not yet, thanks for the suggestion.

      For the moment, I'm struggeling to get it working. ;-)

      I use a "$(document).ready" in my .js file. Looks like this is not executed...

       

Resources