Help with Watcher

Harm_Veenstra only to let you know...

maybe.....i found a little workaround..... i change the operator from match to like

$path = $Event.SourceEventArgs.FullPath
$changeType = $Event.SourceEventArgs.ChangeType
if (-not ($path -like '*_renamed_*')) {

do you see any problems with this solution that i am not aware of?

Harm_Veenstra this is working very fine and at the moment is stable....also the Log File is clear, not doubled as on your side, but in any case i will take a look again when the log will be more full...

there is only a little problem that i found during the test.....is the name of the TAG......

basically if i will create a new test file "renamed_contract.msg" it is obviuosly skipped.

i will try to find a workaround to avoid it.....

Harm_Veenstra is nice to learn every day something new.... i tried to take it to the next step....

obviusly something is again missing.....but at least seems to be stable.

# setting the monitoring folder
$Path = "C:\TEST"

# setting file filter to monitor
$FileFilter = '*.msg'

# setting subfolders
$IncludeSubFolders = $true

# set the file or folder proprieties to monitor
$AttributeFilter = [IO.NotifyFilters]::FileName, [IO.NotifyFilters]::LastWrite

# set the change to monitor
$ChangeTypes = [System.IO.WatcherChangeTypes]::Created

# waiting time (ms)
$Timeout = 1000

#Funtion called for each file creation

function Invoke-SomeAction{
    param(
    [Parameter(Mandatory)]
    [System.IO.WaitForChangedResult]
    $ChangeInformation
    )# closing param
Write-Warning 'New File detected:'
$ChangeInformation | Out-String | Write-Host -ForegroundColor DarkYellow
    if($result.ChangeType -ne 0){
        Invoke-RenameFile -ChangeInformation $result
        }

        
}# closing Invoke-SomeAction




function Invoke-RenameFile{
    param(
    [Parameter(Mandatory)]
    [System.IO.WaitForChangedResult]
    $ChangeInformation
    )# closing param
    $now = Get-Date -Format "yyyyMMddHHmm"
    $file = $result.Name
    $FileName = [System.IO.Path]::GetFileNameWithoutExtension($file)
    $Extension = [System.IO.Path]::GetExtension($file)
    $NewName = "${now}_${FileName}${Extension}"
    Rename-Item -Path $file -NewName $NewName
    Write-Warning 'File Renamed:'
    Write-Host "$NewName"
    }#closing Invoke-RenameFile

#try to unlock the systemwatcher from the CTRL+C abort

try
{
    Write-Warning "FileSystemWatcher is monitoring $Path"

    #create a FileSystemWatcher object
    $watcher = New-Object -TypeName IO.FileSystemWatcher -ArgumentList $Path, $FileFilter -Property @{
        IncludeSubdirectories = $IncludeSubfolders
        NotifyFilter = $AttributeFilter
    }
}
catch [system.exception]{
}


# start monitoring manually
do
{
    $result = $watcher.WaitForChanged($ChangeTypes, $Timeout)
        if($results.TimedOut){continue}

        Invoke-SomeAction -ChangeInformation $result


}while ($true)
    
finally
{
    #release the watcher
    $watcher.Dispose()
    Write-Warning 'FileSystemWatcher removed.'
}

can you please take a look also here?

Harm_Veenstra thank you...this seems more clean code...

now.....i have another little problem that i cannot understand....i used the code below, using the page that you sent me before.....

# setting the monitoring folder
$Path = "C:\TEST"

# setting file filter to monitor
$FileFilter = '*.msg'

# setting subfolders
$IncludeSubFolders = $true

# set the file or folder proprieties to monitor
$AttributeFilter = [IO.NotifyFilters]::FileName, [IO.NotifyFilters]::LastWrite

# set the change to monitor
$ChangeTypes = [System.IO.WatcherChangeTypes]::Created

# waiting time (ms)
$Timeout = 1000

#Funtion called for each file creation

function Invoke-SomeAction{
    param(
    [Parameter(Mandatory)]
    [System.IO.WaitForChangedResult]
    $ChangeInformation
    )# closing param
Write-Warning 'New File detected:'
$ChangeInformation | Out-String | Write-Host -ForegroundColor DarkYellow
}# closing Invoke-SomeAction

#try to unlock the systemwatcher from the CTRL+C abort

try
{
    Write-Warning "FileSystemWatcher is monitoring $Path"

    #create a FileSystemWatcher object
    $watcher = New-Object -TypeName IO.FileSystemWatcher -ArgumentList $Path, $FileFilter -Property @{
        IncludeSubdirectories = $IncludeSubfolders
        NotifyFilter = $AttributeFilter
    }
}
catch [system.exception]{
}


# start monitoring manually
do
{
    $results = $watcher.WaitForChanged($ChangeTypes, $Timeout)
        if($results.TimedOut){continue}

        Invoke-SomeAction -Change $result
}while ($true)
    
finally
{
    #release the watcher
    $watcher.Dispose()
    Write-Warning 'FileSystemWatcher removed.'
}

but...error again....

WARNING: FileSystemWatcher is monitoring C:\TEST
Invoke-SomeAction : Cannot process argument transformation on parameter 
'ChangeInformation'. Cannot convert null to type 
"System.IO.WaitForChangedResult".
At line:53 char:35
+         Invoke-SomeAction -Change $result
+                                   ~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Invoke-SomeAction], ParameterB 
   indingArgumentTransformationException
    + FullyQualifiedErrorId : ParameterArgumentTransformationError,Invoke-Some 
   Action

but i cannot understand why......

Harm_Veenstra it worked only for the first file...........than nothing again i only copied paste the code......

Turion986 

Ok, the last copy/paste of your script doesn't work:

# Cartella da monitorare (stessa cartella)
$FolderToMonitor = "C:\TEST"

# Crea un registro per i file già rinominati
 $RenRegFile = "C:\TEST\registro.txt"
 


function Rename-FileMSG {
    param (
        [string]$file
    )
	Start-Transcript C:\test\script.log
    
    if ($file -match "\.msg$" -and -not $RenRegFile.Contains($file)) {
        $now = Get-Date -Format "yyyyMMddHHmm"
        $nameFile = [System.IO.Path]::GetFileNameWithoutExtension($file)
        $extension = [System.IO.Path]::GetExtension($file)
        $newName = "${now}_${nameFile}${extension}"
        Rename-Item -Path $file -NewName $newname
        Write-Host "$file renamed in $newname"
        $RenRegFile[$file] = $true
    }
    
}

# Crea un oggetto FileSystemWatcher per monitorare la cartella
$watcher = New-Object System.IO.FileSystemWatcher
$watcher.Path = $FolderToMonitor
$watcher.Filter = "*.msg"
$watcher.IncludeSubdirectories = $true
$watcher.EnableRaisingEvents = $true

# Associa l'azione all'evento Created e Renamed
Register-ObjectEvent -InputObject $watcher -EventName Created -Action $action
Register-ObjectEvent -InputObject $watcher -EventName Renamed -Action $action

while ($true) {


# Azione da intraprendere quando viene rilevato un nuovo file
$action = {
    $changeType = $Event.SourceEventArgs.ChangeType
    $file = $Event.SourceEventArgs.FullPath
    if ($changeType -eq "Created" -or $changeType -eq "Renamed") {
        Rename-FileMSG -file $file
    }
}


# Attendi che lo script venga interrotto
Write-Host "Waiting for new MSG files..."

   Start-Sleep -Seconds 30
}

This one does work:

# Cartella da monitorare (stessa cartella)
$FolderToMonitor = "C:\TEST"

# Crea un registro per i file già rinominati
 $RenRegFile = "C:\TEST\registro.txt"
 


function Rename-FileMSG {
    param (
        [string]$file
    )
	Start-Transcript C:\test\script.log
    
    if ($file -match "\.msg$" -and -not $RenRegFile.Contains($file)) {
        $now = Get-Date -Format "yyyyMMddHHmm"
        $nameFile = [System.IO.Path]::GetFileNameWithoutExtension($file)
        $extension = [System.IO.Path]::GetExtension($file)
        $newName = "${now}_${nameFile}${extension}"
        Rename-Item -Path $file -NewName $newname
        Write-Host "$file renamed in $newname"
        $RenRegFile[$file] = $true
    }
    
}

# Crea un oggetto FileSystemWatcher per monitorare la cartella
$watcher = New-Object System.IO.FileSystemWatcher
$watcher.Path = $FolderToMonitor
$watcher.Filter = "*.msg"
$watcher.IncludeSubdirectories = $true
$watcher.EnableRaisingEvents = $true

# Associa l'azione all'evento Created e Renamed
Register-ObjectEvent -InputObject $watcher -EventName Created -Action $action
Register-ObjectEvent -InputObject $watcher -EventName Renamed -Action $action

while ($true) {


# Azione da intraprendere quando viene rilevato un nuovo file
$action = {
    $changeType = $Event.SourceEventArgs.ChangeType
    $file = $Event.SourceEventArgs.FullPath
    if ($changeType -eq "Created" -or $changeType -eq "Renamed") {
        Rename-FileMSG -file $file
    }
}


# Attendi che lo script venga interrotto
Write-Host "Waiting for new MSG files..."

   Start-Sleep -Seconds 30
}

Harm_Veenstra i added a pause in the middle of the code and now i have this error back 

Exception setting "EnableRaisingEvents": "The path is not of a legal form."
At C:\Users\Test\Desktop\Test - Copy.ps1:33 char:1
+ $watcher.EnableRaisingEvents = $true
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
    + FullyQualifiedErrorId : ExceptionWhenSetting

Harm_Veenstra this is what i have with the script that for you works.....nothing back....

i cannot really understand waht i am doing wrong...