Windows Server 2012 to Windows Server 2019 upgrade

Hello!

I am planning to upgrade our fileserver currently running WS2012R2 to WS2019.  

What is the best way to upgrade? I have performed a in-place upgrade on a test VM and it all seemed to work fine with all shares and permissions retained.

Thanks