Need help importing user data from csv

I need to fill in the Manager Attribute for employee accounts using a CSV export from HR. I have the added bonus of the fact that SamAccountNames do not follow a consistent naming convention. So I ne...

Active Directory (AD)

powershell

LainRobertson

Jun 28, 2022

Harm_Veenstra

Hey, Harm.

I'd strongly recommend using the -Filter parameter in the Get-AD* calls, as you're current pulling every single user in Active Directory client-side before filtering anything - twice.

In smaller environments, that won't be an issue, but it'll run into scalability issues rather quickly.

Using your original example, something like this would be more efficient in medium to large directories:

$csv = import-csv c:\scripts\accounts.csv
foreach ($line in $csv) {
    $user = Get-ADUser -Filter "employeeID -eq '$($line.EmployeeID)'";          # Here, we're now leveraging server-side filtering.
    $manager = Get-ADUser -Filter "employeeID -eq '$($line.SupervisorID)'";     # And again here.

    if ($user -is [Microsoft.ActiveDirectory.Management.ADUser] -and $manager -is [Microsoft.ActiveDirectory.Management.ADUser])
    {
        # We only want to be in here where we got precisely one user and one manager, otherwise we have no way to arbitrate who gets updated with what.
        Set-ADUser $user -Manager $manager
    }
}

Cheers,

Lain

Baron164

Brass Contributor

Jun 27, 2022

Harm_Veenstra Thank you, that is very helpful. It's looks to be working, I see the manager information being filled in. The only issue I see is that the script spits out an error each time it runs the "Set-ADUser" line.

I tried changing the line to "Set-ADUser -Identity $user but that did not make a difference.

Harm_Veenstra

MVP

Jun 27, 2022

Baron164 How many users are you updating? Are they all updated? I think it throws an error if it can't find the user with the search for the employeeid... Could you try this?

$csv = import-csv c:\scripts\accounts.csv
foreach ($line in $csv) {
try {
    $user = Get-ADUser -Filter * -Properties EmployeeID | Where-Object EmployeeID -eq $line.EmployeeID
}
catch {
Write-host Could not find a user matching $line.EmployeeID
}

try {
    $manager = Get-ADUser -Filter * -Properties EmployeeID | Where-Object EmployeeID -eq $line.SupervisorID
}
catch {
write-host Could not find a user matching $line.SupervisorID
}

try {
    Set-ADUser $user -Manager $manager
}
catch {
write-host Error setting $manager on $user
}
}

(Added some error handling)

Forum Discussion

Need help importing user data from csv

Resources