Forum Discussion

Arnaud Landry's avatar
Arnaud Landry
Brass Contributor
Apr 29, 2017

Code Review Guidelines

Hello everyone,

 

Are you using code review in your team ? (i do but still got a lot of questions)

 

* Do you use a guideline? like this https://www.reddit.com/r/PowerShell/comments/4dauu1/powershell_code_review_guidelines/ (by Mike Shepard)?

 

* Do you use PowerShell/https://github.com/PowerShell/PSScriptAnalyzer in your code review?

 

* What's your process if you have one?

 

Thanks,

Arnaud

powershell

2 Replies

Sort By
  • Ryan Bartram's avatar
    Ryan Bartram
    Copper Contributor
    Jul 13, 2017

    We use PSScriptAnalyser with custom rules and Pester Unit tests. On commit to GIT we check that Test are good and Code Coverage is high. Check out any of Microsoft DSC Resource GIT Repos to see how they use appveyor and codecov.

  • Mats Warnolf's avatar
    Mats Warnolf
    Brass Contributor
    May 04, 2017
    Well I'm a Steroids user so I get that taken care of. But I agree with Mike Shepard that scripts that are anything but private should maintain a high level of readability and be very robust.

Resources